Repository navigation
Fix some tests failing when run with --verbose/--quiet. - #1996
Merged
Merged
Conversation
Some of our tests are sensitive to the verbosity level set at call time because they test the textual output to the console or to the JSON stream. These tests create `Configuration` values with default verbosity, but `Runner` has logic to pop the configuration before it calls event handlers, which causes us to go back to the configuration created at process start. If that configuration has non-default verbosity, the resulting strings will be generated incorrectly. This PR adjusts the logic of those tests to tell `Runner` _not_ to pop the configuration. This means they can't call `#expect()` from within their local event handlers, but they're not designed to do so anyway and are instead just collecting strings for later analysis.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
October 30, 2026 19:09
Contributor
Author
|
@swift-ci test |
harlanhaskins
approved these changes
Oct 30, 2026
harlanhaskins
left a comment
harlanhaskins
left a comment
Contributor
There was a problem hiding this comment.
This seems okay and isolated enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our tests are sensitive to the verbosity level set at call time because they test the textual output to the console or to the JSON stream. These tests create
Configurationvalues with default verbosity, butRunnerhas logic to pop the configuration before it calls event handlers, which causes us to go back to the configuration created at process start. If that configuration has non-default verbosity, the resulting strings will be generated incorrectly.This PR adjusts the logic of those tests to tell
Runnernot to pop the configuration. This means they can't call#expect()from within their local event handlers, but they're not designed to do so anyway and are instead just collecting strings for later analysis.This change does not affect test code outside Swift Testing itself.
Checklist: