fix: ensure that @Nullable does not incorrectly affect object schemas#5124
Open
Mattias-Sehlstedt wants to merge 2 commits intoswagger-api:masterfrom
Open
fix: ensure that @Nullable does not incorrectly affect object schemas#5124Mattias-Sehlstedt wants to merge 2 commits intoswagger-api:masterfrom
Mattias-Sehlstedt wants to merge 2 commits intoswagger-api:masterfrom
Conversation
Mattias-Sehlstedt
force-pushed
the
do-not-set-nullable-on-objects
branch
from
a528240 to
3043ce4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Changes so that a
@Nullableannotation present on a model does not incorrectly settype: nullfor OAS 3.1 ornullable: truefor OAS 3.0. The nullable is instead dropped entirely. This since the resolving currently does not support an easy way of expressing nullable withrefs correctly.Fixes: #5115
Type of Change
Checklist
Screenshots / Additional Context