fix: remove the default defect-group cap - #87
Merged
Merged
Conversation
svozza
had a problem deploying
to
ai-pr-review-runtime
October 1, 2026 22:54 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review can have fewer than ten finding entries and still be rejected by the shipped four-defect-group cap. On Cal.com, that cap pushed confirmed concerns into residual risk and repeatedly missed the Office365 destination defect.
Ship
review.max_distinct_groups: nulland state the effective group policy in the generated constraints. Keep the ten-entry maximum, required group field, numeric group range and all provenance/output checks. Numeric consumer caps remain supported and are disclosed in the prompt. Runtime files match the evaluated no-cap candidate exactly; the additional changes update the default-policy tests and architecture/ADR documentation. An evaluation-only correction also addresses the grouping fixture’s documented rejection of an optional root-cause finding; its exact path/line/diagnosis matcher preserves required callers and rejects unrelated or split groups. No reviewer input changes accompany that correction.The completed direct comparison against shipped
8b91cb5used three paired repetitions across six frozen source snapshots (36 reviews). Known target delivery improved from 18/24 to 21/24, recovering Office365 in all three candidate runs versus none in control. Summed review time fell 5.57% and submission rejections fell 5 to 0. Both arms still had one false structured finding and incomplete repair advice; repeated nonexhaustive targets do not establish general accuracy. Raw source assessments remain private/local.Validation:
Final-head evaluation runs: 1, 2, 3. Deterministic CI: Quality check.