Repository navigation
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/260ec14126141bc72074a2cb738c7c041d1f8221Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 260ec14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ottomated
left a comment
There was a problem hiding this comment.
This is good but the tests aren't really testing anything; maybe we need a type checking test that pulls the latest @cloudflare/workers-types to check compatibility with their interfaces.
ff6b84e to
260ec14
Compare
|
Fair enough, thanks for the feedback @ottomated! I decided to just scrap those test cases altogether. The types are already checked in CI by TypeScript anyway thanks to the As far as the automated "check if the latest
|
This PR updates the local Cloudflare emulation to now shim
Span#setStatusandSpan#updateName(first introduced in@cloudflare/workers-types@5.20260925.1) as no-op methods.return thisshim to bothsetStatusandupdateName.@cloudflare/workers-types@5.20260925.1so that there are no duplicated versions. I could've bumped the version much higher, but I think it's good to use the minimally sufficient version here for maximum compatibility.Ran into this crash during local development in one of my projects, but it does work in the production deployment with Cloudflare Workers. I guess they just haven't updated the docs yet, but
setStatusis indeed available now.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits