housekeeper: remove dead signOut export from auth-client#142
Open
lufen wants to merge 1 commit into
Open
Conversation
signOut was destructured from better-auth's client but never consumed anywhere in the repo (signIn and useSession are both live, e.g. SignIn.tsx). Removing the unused binding; authClient itself still exposes signOut directly if ever needed. Verified: pnpm -r typecheck green; pnpm --filter @loopany/server test shows the same baseline pass/fail set as unmodified main (pre-existing env-specific timeouts/tmp-path failures, unrelated to this change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
signOutbinding destructured inpackages/server/src/lib/auth-client.ts.Evidence
rg '\bsignOut\b'across the repo → only its own declaration inauth-client.ts. No component/route/test consumes it.signIn(SignIn.tsx) anduseSession(used across auth-gated views).authClientitself still exposessignOutdirectly (authClient.signOut) if a future caller needs it — this only drops the unused destructured binding.Checks:
pnpm -r typecheck(both packages) green.pnpm --filter @loopany/server testshows the same baseline pass/fail set as unmodifiedmainin this sandbox (pre-existing env-specific timeouts/tmp-path failures unrelated to this change — verified by running the suite against main unmodified).Made in a throwaway worktree off
origin/main; the owner's checkout was never dirtied.