Repository navigation
fix: allow UBSAN/ASAN options to be overridden - #26
Merged
Merged
Conversation
steve-chavez
approved these changes
Nov 10, 2026
steve-chavez
requested changes
Nov 10, 2026
steve-chavez
left a comment
steve-chavez
left a comment
Member
There was a problem hiding this comment.
Sorry, approved too son, there's a failure on CI
/nix/store/4k7lh7g44qhbqdg6kd6dxsrly3a4zkvl-xpg14/bin/xpg14: line 48: UBSAN_OPTIONS: unbound variable
Member
|
Also perhaps these options should be passed via command line? |
steve-chavez
approved these changes
Nov 10, 2026
Contributor
Author
I thought that our long term goal was more around exposing paths and using native tools like make, etc instead of providing commands and subcommands within xpg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.