Repository navigation
fix: strict qualification - #84
Draft
AndrewJackson2020 wants to merge 5 commits into
Draft
AndrewJackson2020 wants to merge 5 commits into
AndrewJackson2020 wants to merge 5 commits into
Conversation
Contributor
Author
|
Tests are fine, macOS CI is going to fail until the below PR gets merged. |
AndrewJackson2020
force-pushed
the
strict_qualification
branch
from
November 11, 2026 17:14
87ae069 to
f562fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the latest development head of
plpgsql_checkto test out the strict schema qualification of referenced objects in functions. For demonstration purposes I have set it to mode 4 meaning every function, type, and operator must be schema qualified. There is some degradation in readability but the increase in security is may be worth it.Interestingly TIL not all functions have schemas. coalesce for example. I believe that these are being flagged as false positives. I need to follow up with the maintainers if that is in fact that case.