Repository navigation
test: role spec forms and unset settings - #269
Open
utkarash2991 wants to merge 3 commits into
Open
utkarash2991 wants to merge 3 commits into
utkarash2991 wants to merge 3 commits into
Conversation
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-role-tests
branch
from
October 29, 2026 12:44
0c673d3 to
656030f
Compare
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-role-tests
branch
2 times, most recently
from
October 29, 2026 23:01
4007ebb to
49bbfaf
Compare
xpg now installs src/test/modules/unsafe_tests into its regress output. Pinned to the commit until the next xpg tag.
None of these forms names a role, so the hook has nothing to check and every one of them has to end in core's own permission error. The IN DATABASE form was not exercised anywhere else.
Move the supautils settings from init.conf to an alter system block in init.sql so a test can reset them to their defaults. settings_unset does that, reconnects, and runs role, extension and policy statements as nonsuper and privileged_role; all of them have to fall through to core.
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-role-tests
branch
from
November 1, 2026 12:13
49bbfaf to
ec87abc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tests for cases no existing test covers.
role_spec_formsruns thealter role allforms, includingin database, as nonsuper and privileged_role. None of them names a role, so all of them should end in core's own permission error.settings_unsetresets every supautils setting to its default, reconnects, and runs a few role, extension and policy statements as nonsuper and privileged_role. All of them should fall through to core. Forresetto reach the default, the settings move from init.conf to analter systemblock in init.sql.Stacked on #260.