Repository navigation
feat(pgbouncer): add m8g instance memory - #1694
Closed
TylerHillery wants to merge 1 commit into
Closed
TylerHillery wants to merge 1 commit into
TylerHillery wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the M8g instance memory-mapping change.
No open issues 🎉
What changed in this PR
Adds M8g instance memory mappings to PgBouncer’s entrypoint so these instances use known memory values instead of falling back to local defaults.
Changes:
- Adds nine M8g sizes, from
db.m8g.largethroughdb.m8g.48xlarge, with memory values from 8 to 768 GB.
| File | Description |
|---|---|
.docker/pgbouncer/entrypoint.sh |
Adds M8g mappings to get_instance_memory_gb(). |
Review effort: Balanced
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
TylerHillery
changed the title
Coverage Report for CI Build 43099076507Coverage remained the same at 87.646%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Chore
What is the current behavior?
get_instance_memory_gb()in the entrypoint for PgBouncer doesn't have m8g family instancesWhat is the new behavior?
Added them
Additional context