Skip to content

feat: add noncurrent lifecycle executor - #1687

Merged
ferhatelmas merged 1 commit into
masterfrom
ferhat/lc-executor
Nov 10, 2026
Merged

ferhatelmas merged 1 commit into
masterfrom
ferhat/lc-executor

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

feat

What is the current behavior?

#1627 and #1683 added the database operations and outbox needed for noncurrent lifecycle deletion but executor to run was missing.

What is the new behavior?

Add a bucket executor that evaluates archived versions, deletes eligible metadata in bounded batches and removes the corresponding backend artifacts.
Failed artifact deletions remain in the outbox for retry.

Additional context

Scheduling the executor and retry helper is a next separate change.

@ferhatelmas
ferhatelmas requested a review from a team as a code owner November 9, 2026 23:10
Copilot AI balanced review requested due to automatic review settings November 9, 2026 23:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coveralls

coveralls commented Nov 9, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 42856954115

Coverage increased (+0.1%) to 87.603%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (149 of 150 lines covered, 99.33%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/storage/lifecycle/executor.ts 90 89 98.89%
Total (5 files) 150 149 99.33%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16052
Covered Lines: 14504
Line Coverage: 90.36%
Relevant Branches: 10188
Covered Branches: 8483
Branch Coverage: 83.26%
Branches in Coverage %: Yes
Coverage Strength: 1354.26 hits per line

💛 - Coveralls

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread src/storage/lifecycle/executor.ts Resolved
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
@ferhatelmas
ferhatelmas enabled auto-merge (squash) November 10, 2026 16:39
@ferhatelmas
ferhatelmas merged commit 2d91d09 into master Nov 10, 2026
35 checks passed
@ferhatelmas
ferhatelmas deleted the ferhat/lc-executor branch November 10, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants