Repository navigation
fix: improve detailed delete outcome classification - #1557
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Coverage Report for CI Build 39396875695Coverage increased (+0.04%) to 85.804%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
TylerHillery
approved these changes
Oct 20, 2026
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/lifecycle-1
branch
from
October 20, 2026 08:55
8f800e1 to
a6edd17
Compare
ferhatelmas
enabled auto-merge (squash)
October 20, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Detailed deletion returns per-key outcomes without cancellation.
S3 marks every per-key error as
FAILEDand request failures asUNKNOWNand file errors are always UNKNOWN.An XML-invalid key can fail an entire S3 batch.
What is the new behavior?
Both backends support cancellation and distinguish definite failures from uncertain outcomes. S3 keeps retry/timeout ambiguity as
UNKNOWN, treatsNoSuchKeyas success and sends XML-invalid keys individually.File deletion treats overlong paths as absent and stops starting work after cancellation while preserving completed results.
Additional context
Related to #1380