Force CREATE EXTENSION through the upgrade chain + fix CI + add PG17

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        pg: [15]
+        pg: [15, 17]
 
     steps:
       - name: Start PostgreSQL ${{ matrix.pg }}
@@ -21,13 +21,13 @@ jobs:
       - name: Install build-dependencies
         run: apt-get install -y liblz4-dev libreadline-dev zlib1g-dev libzstd-dev
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: checkout hypopg
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: 'HypoPG/hypopg'
-          ref: 'debian/1.3.1-2'
+          ref: '1.4.3'
           path: ./hypopg
 
       - name: Create tests directory
@@ -52,7 +52,7 @@ jobs:
         if: ${{ failure() }}
         run: cat regress/regression.diffs
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: regression.out

index_advisor--0.2.0.sql → index_advisor--0.1.2--0.2.0.sql

@@ -1,4 +1,6 @@
-create or replace function index_advisor(
+drop function index_advisor(text);
+
+create function index_advisor(
     query text
 )
     returns table  (

test/expected/create_extension_default_version.out

@@ -0,0 +1,15 @@
+begin;
+    -- Unversioned CREATE EXTENSION must resolve through the full upgrade
+    -- chain (0.1.0 -> 0.1.1 -> 0.1.2 -> default_version), since only 0.1.0
+    -- exists as a standalone install script - everything after that is only
+    -- reachable via incremental upgrade scripts. Confirms the chain is
+    -- unbroken end to end, not just reachable via an explicit version pin.
+    create extension index_advisor cascade;
+NOTICE:  installing required extension "hypopg"
+    select extversion from pg_extension where extname = 'index_advisor';
+ extversion 
+------------
+ 0.2.0
+(1 row)
+
+rollback;

test/expected/upgrade_from_oldest_version.out

@@ -0,0 +1,29 @@
+begin;
+    -- Simulates a project that installed index_advisor at its very first
+    -- version and later runs ALTER EXTENSION ... UPDATE (e.g. during a
+    -- Postgres major-version upgrade, or a manual extension update) -
+    -- exercises the full 0.1.0 -> 0.1.1 -> 0.1.2 -> default_version upgrade
+    -- chain end to end, including the 0.1.2->default_version return-type
+    -- change (drop + recreate), not just a fresh install pinned at one
+    -- version.
+    create extension index_advisor version '0.1.0' cascade;
+NOTICE:  installing required extension "hypopg"
+    alter extension index_advisor update;
+    select extversion from pg_extension where extname = 'index_advisor';
+ extversion 
+------------
+ 0.2.0
+(1 row)
+
+    create table public.book(
+        id int
+    );
+    select index_advisor($$
+        select * from book where id = $1
+    $$);
+                                  index_advisor                                  
+---------------------------------------------------------------------------------
+ (0.00,4.13,41.88,14.83,"{""CREATE INDEX ON public.book USING btree (id)""}",{})
+(1 row)
+
+rollback;

test/sql/create_extension_default_version.sql

@@ -0,0 +1,12 @@
+begin;
+
+    -- Unversioned CREATE EXTENSION must resolve through the full upgrade
+    -- chain (0.1.0 -> 0.1.1 -> 0.1.2 -> default_version), since only 0.1.0
+    -- exists as a standalone install script - everything after that is only
+    -- reachable via incremental upgrade scripts. Confirms the chain is
+    -- unbroken end to end, not just reachable via an explicit version pin.
+    create extension index_advisor cascade;
+
+    select extversion from pg_extension where extname = 'index_advisor';
+
+rollback;

test/sql/upgrade_from_oldest_version.sql

@@ -0,0 +1,24 @@
+begin;
+
+    -- Simulates a project that installed index_advisor at its very first
+    -- version and later runs ALTER EXTENSION ... UPDATE (e.g. during a
+    -- Postgres major-version upgrade, or a manual extension update) -
+    -- exercises the full 0.1.0 -> 0.1.1 -> 0.1.2 -> default_version upgrade
+    -- chain end to end, including the 0.1.2->default_version return-type
+    -- change (drop + recreate), not just a fresh install pinned at one
+    -- version.
+    create extension index_advisor version '0.1.0' cascade;
+
+    alter extension index_advisor update;
+
+    select extversion from pg_extension where extname = 'index_advisor';
+
+    create table public.book(
+        id int
+    );
+
+    select index_advisor($$
+        select * from book where id = $1
+    $$);
+
+rollback;