Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ai-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ jobs:
# specifically to stop that from happening again. There is no
# released fix above v1.12 as of 2026-09-09; re-verify both issues
# are closed before ever re-bumping this pin.
uses: &codex-action-pin openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11
uses: &codex-action-pin openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: LOW

The added SHA is the v1.12 release, not v1.11 as the inline annotation and surrounding security rationale state. This silently changes the privileged action wrapper used with untrusted PR content and OPENAI_API_KEY; the v1.11 isolation audit no longer applies, leaving a plausible path for a wrapper regression to expose the key.
Helpful? Add 👍 / 👎

💡 Fix Suggestion

Suggestion: Revert the SHA on line 347 back to the v1.11 SHA (52fe01ec70a42f454c9d2ebd47598f9fd6893d56). The PR accidentally bumped the pin to v1.12 (86365089eb2b84e0a8fb0717b304f8bdcb13b20e), which the surrounding comments (lines 330–346) explicitly forbid due to two confirmed upstream regressions (openai/codex-action#151 and #160) that hang or kill the job under this workflow's exact configuration. The dependabot.yml ignore entry for openai/codex-action exists precisely to prevent this bump, but it was overridden here.

⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.

Suggested change
uses: &codex-action-pin openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.11
uses: &codex-action-pin openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11

with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: .github/ai-review/codex-review-prompt.md
Expand Down
Loading