Skip to content

fix: reject timestamps above sortable range - #30

Merged
suhailopensource merged 1 commit into
suhailopensource:mainfrom
gt12889:fix/timestamp-range
Sep 5, 2026
Merged

suhailopensource merged 1 commit into
suhailopensource:mainfrom
gt12889:fix/timestamp-range

Conversation

@gt12889

@gt12889 gt12889 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Closes #29

Summary

  • Reject decoded timestamps above SORTABLE_TIME_MAX in getTimestamp.
  • Let getTimestampOrThrow surface the malformed-ID error through its existing path.
  • Add regression coverage and update the Date-boundary expectation required by the sortable range contract.
  • Document the behavior under Unreleased.

Verification

  • npm test — 116 passed.
  • npm run typecheck — passed.
  • Touched files pass Prettier.
  • npm run verify reaches the repository-wide format gate but is blocked by 28 pre-existing unformatted files outside this change.

@suhailopensource
suhailopensource merged commit deea190 into suhailopensource:main Sep 5, 2026
7 checks passed
@suhailopensource

Copy link
Copy Markdown
Owner

Thanks for the PR @gt12889 . code LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] : getTimestamp() returns a nonsense timestamp for non-sortable IDs

2 participants