test: add parseId coverage to smoke tests - #28
Merged
suhailopensource merged 3 commits intoSep 4, 2026
Merged
Conversation
Owner
|
@Nityam43 the extra spaces in the PR in smoke file |
Owner
|
Other than That the Code looks good to me . Thanks. Do star the Repo. |
Contributor
Author
|
Done! I've removed the extra spaces in |
Owner
|
@Nityam43 i also removed the blank lines . instead of sending u for another round. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Expands the repository's cross-runtime smoke tests to include validation for the
parseIdfunction. This ensures that the newest public API is actively exercised in CI across Node.js (both ESM and CJS) and browser environments prior to release.🛠️ Changes Made
parseIdassertions toscripts/smoke.mjs,scripts/smoke.cjs, andscripts/browser-smoke.html.{ prefix, id }."nosep") safely returnundefined.null) are handled safely and returnundefined.✅ Verification
All local tests and CI checks pass cleanly:
npm run smoke(Validated across Node ESM and CJS)npm run verify(Prettier formatting, TypeScript typings, and all CI checks are perfectly green)Closes #20