fix(spark): preserve aggregate outputs in projections - #1263
Draft
bvolpato wants to merge 1 commit into
Draft
Conversation
Retain inherited aggregate expressions before appending project outputs and applying emit mapping, preserving the existing aggregate folding.
bvolpato
force-pushed
the
bvolpato/fix-spark-aggregate-project
branch
from
September 4, 2026 16:24
290cd5d to
35632b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Substrait Project follows an Aggregate, Spark conversion folds the projection into the aggregate but replaces the inherited outputs with only the appended expressions and ignores emit mapping. An aggregate row [1, 30] followed by a project adding 99 therefore becomes [99] instead of [1, 30, 99]; an emit selecting the original grouping column also returns the wrong value.
Preserve the aggregate's existing named expressions, append the project expressions, and apply emit mapping to that complete list, as required by spec v0.102.0. Keep the existing aggregate folding so projected aggregates retain their Spark round-trip shape.