fix: preserve mandatory read and post-join filters - #1260
Draft
bvolpato wants to merge 1 commit into
Draft
Conversation
Apply embedded read predicates before emit remapping and post-join predicates against the actual join output in Isthmus and Spark. Decode post-join references using the output schema so outer-join nullability survives protobuf conversion.
bvolpato
force-pushed
the
bvolpato/fix-mandatory-predicates
branch
from
September 4, 2026 16:20
021e0c4 to
65eea25
Compare
Contributor
|
Heads-up on an overlap: The two compose: the filter stays on the scan, the mask goes above it, the emit mapping above that -- a filter is read against the direct schema, before the projection (spec v0.102.0, Read Filtering). Whichever of us lands second rebases, and I am glad to be that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mandatory ReadRel filters and JoinRel post-join filters are currently dropped when converting plans to Calcite or Spark. A read carrying FALSE therefore returns its input rows, and an outer join loses predicates that should inspect its null-extended output.
For example, this scan must produce no rows, but Isthmus currently returns an unrestricted TableScan:
Apply mandatory scan filters before emit remapping and post-join filters after the join, using the actual output schema. Decode protobuf post-join references against that same schema so outer-join nullability is preserved and IS NULL cannot be incorrectly simplified away. These semantics follow spec v0.102.0.
Partially addresses #1204 for mandatory read filtering.