Skip to content

Various build improvements#40

Open
dmacvicar wants to merge 5 commits into
subspacecloud:masterfrom
dmacvicar:standard_build
Open

Various build improvements#40
dmacvicar wants to merge 5 commits into
subspacecloud:masterfrom
dmacvicar:standard_build

Conversation

@dmacvicar

Copy link
Copy Markdown
  • Switch to using go modules
    • go builddoes the right thing
    • Note: I did not check go.sum in, but it can also be done
  • Use go-bindata via go generate
    • go-bindata is fetched as any other dependency
  • Decouple build logic from the container
  • Allows to build the same without the container. Put the logic in a Makefile and use that in the container
  • Note that in any case there is no need for go getanymore

@Fastidious

Copy link
Copy Markdown

With six open PRs, and no much happening, I am afraid the developer(s) aren't much active, if at all. 😢

@agonbar

agonbar commented Mar 2, 2020

Copy link
Copy Markdown

This project seems dead, and the maintainer its obviously missing, as proposal:

https://github.com/subspacecommunity/subspace

@dmacvicar I'm creating this and accepting any PR that seems logic, can I merge this fixes? or maybe do the PR e. I guess I'll spam this to all the other PRs.

@dmacvicar

Copy link
Copy Markdown
Author

Thanks for merging those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants