Repository navigation
chore(deps): update detekt to 2.0.0-alpha.6 - #770
Conversation
detekt 2.0.0 is not stable yet but the lack of (recent java version) support in 1.x is becoming more and more of an issue (cf. failing tests since the last GitHub action runner update). Unfortunately, this no longer seems to detect unused imports properly so let's have ktLint handle them instead.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update the plugin and unused-import rules gradle/libs.versions.toml, buildSrc/src/main/kotlin/library-conventions.gradle.kts, config/detekt.yml, .editorconfig |
The version catalog and build conventions now use the dev.detekt plugin marker and ID. The Detekt unused-import rule configuration was removed, and ktlint’s no-unused-imports rule was enabled. |
Possibly related issues
stuebingerb/KGraphQL#33— This change updates the Detekt dependency listed in the issue to version 2.0.0-alpha.6.
Priority:
Change: Other
Merge Risk: 
a5918
-
No actionable merge-blocking risk is established for this change.
Pre-merge checks: 
-
Check name Status Explanation Description check The description explains the Detekt upgrade and the decision to use ktLint for unused-import detection. It directly relates to the changeset. Title check The title follows the conventional commits format, identifies the Detekt update, and is concise at 43 characters. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
stuebingerb
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Architecture diagram
sequenceDiagram
participant Gradle as Gradle Build
participant Detekt as Detekt Plugin (dev.detekt 2.0.0-alpha.6)
participant Ktlint as KtLint Plugin
participant EditorConfig as .editorconfig
participant DetektConfig as config/detekt.yml
Note over Gradle,DetektConfig: Build-Time Dependency Resolution
Gradle->>Gradle: Resolve version catalog (libs.versions.toml)
Gradle->>Detekt: Apply plugin via library-conventions.gradle.kts
Gradle->>Ktlint: Apply plugin via library-conventions.gradle.kts
Note over Detekt,DetektConfig: Static Analysis Configuration
Detekt->>DetektConfig: Load config/detekt.yml
DetektConfig-->>Detekt: Ruleset configuration (UnusedImports removed)
Note over Ktlint,EditorConfig: Linting Configuration
Ktlint->>EditorConfig: Load .editorconfig
EditorConfig-->>Ktlint: Ruleset (UnusedImports rule enabled)
Note over Detekt,Ktlint: Analysis Execution
alt Source code scanning
Detekt->>Detekt: Run static analysis (except unused imports)
Ktlint->>Ktlint: Run linting (including unused imports)
end
Note over Gradle: Build output with both analysis results
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
+ Coverage 84.21% 84.23% +0.01%
==========================================
Files 150 150
Lines 5024 5024
Branches 869 869
==========================================
+ Hits 4231 4232 +1
Misses 493 493
+ Partials 300 299 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
detekt 2.0.0 is not stable yet but the lack of (recent java version) support in 1.x is becoming more and more of an issue (cf. failing tests since the last GitHub action runner update).
Unfortunately, this no longer seems to detect unused imports properly so let's have ktLint handle them instead.