Repository navigation
[Chore] Run the workflows on Ubuntu runners - #722
Merged
Merged
Conversation
The macOS runners queued for hours behind other runs, and GitHub cancelled a code-quality job that never started. Ubuntu runners have more capacity. Playwright installs the system libraries of Chromium with --with-deps on Ubuntu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GW27xi1rHPvuZNXwCqzHFN
Code ReviewRisk: Low — The workflow runner migration is safe to merge; no blocking issues were found. Moves the build, tests, code-quality, and release test jobs from macOS to Ubuntu runners. It also updates the Playwright installation steps to install Chromium's Ubuntu system dependencies through apt. Review usage: 8,867 in / 191 out tokens — $0.0024 (openrouter/openai/gpt-5.6-luna, thinking: low) Reviewed by @weareikko/code-review v0.11.1 for commit d014b2d. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #722 +/- ##
=========================================
Coverage 86.32% 86.32%
Complexity 145 145
=========================================
Files 20 20
Lines 746 746
Branches 88 88
=========================================
Hits 644 644
Misses 95 95
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Move every
macos-latestjob (tests,build,code-qualityand theTestjob ofrelease) toubuntu-latest. On #718, the macOS jobs waited for hours behind the Renovate runs, and GitHub cancelledphpstan (8.5)with "The job was not acquired by Runner of type hosted even after multiple attempts".Playwright now installs Chromium with
--with-deps, which installs its system libraries through apt on Ubuntu.The
Testjob ofpublish.ymlonly runs on a merge, but it has the same steps asunit_nodeintests.yml, which this PR runs.📝 Checklist
.changelog/(or set theno-changeloglabel).🤖 Generated with Claude Code
https://claude.ai/code/session_01GW27xi1rHPvuZNXwCqzHFN