Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@mapbox/mapbox-gl-geocoder": "^5.1.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Pinning retains the vulnerable deepmerge release

4.3.1 is the vulnerable version identified by the cited CVE and advisory, so changing the range to an exact pin does not remediate prototype poisoning. Pin deepmerge to the first release that contains the security fix instead.

Confidence: high.


Reviewed by @weareikko/code-review v0.11.0 for commit 84b7ecd.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Pinning retains the vulnerable deepmerge version

The referenced advisory explicitly says deepmerge versions through 4.3.1 are vulnerable, so changing ^4.3.1 to 4.3.1 does not remediate the prototype-poisoning issue and prevents installation of a later fixed release. Pin a version newer than the vulnerable range instead.

Confidence: high.


Reviewed by @weareikko/code-review v0.11.1 for commit 82b5729.

"@motionone/easing": "^10.18.0",
"@studiometa/js-toolkit": "4.0.0-alpha.1",
"deepmerge": "^4.3.1",
"deepmerge": "4.3.1",
"gsap": "^3.13.0",
"mapbox-gl": "^3.13.0",
"morphdom": "^2.7.8",
Expand Down
Loading