Repository navigation
Fuse the pusher preamble into one CUDA kernel - #708
Open
max-models wants to merge 3 commits into
Open
max-models wants to merge 3 commits into
max-models wants to merge 3 commits into
Conversation
7 tasks
Stack the PR on #709. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
max-models
added a commit
that referenced
this pull request
Oct 7, 2026
Stack the PR on #708. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
Draft
max-models
added this pull request to stack #729
October 8, 2026 05:59
max-models
marked this pull request as draft
October 8, 2026 09:15
max-models
marked this pull request as ready for review
October 8, 2026 11:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: part 2 of 14, based on #709 (merge that first), next: #711. Full order: #709 → #708 → #711 → #712 → #705 → #713 → #714 → #718 → #720 → #721 → #724 → #725 → #723 → #722.
Fuse the pusher preamble into one CUDA kernel
On the CuPy backend, the three column-slice assignments at the start of
Pusher._pusheach sweep the whole row-major marker buffer, because the slices are strided. With 4M markers (an 8M-row buffer of 1.66 GB), this took 4.6 ms per pusher call, more than the push kernels themselves.
Changes
This roughly speeds up the preamble by 2x.
The next big improvement for the markers would be #707