Fix CodeTile background#1484
Open
MathCatsAnd wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@jrieke There is another contribution to fix this same issue differently, but I think it might require dealing with some additional cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Context
When the code blocks were reworked to add the headers, and exception was carved out to make them always dark in most places, but not the API ref cards. The cheat sheet fell through the cracks when this exception was implemented, adding and locking in the side fades, but not the text colors and background.
🧠 Description of Changes
As a minimal fix, this PR removes the side fades from the cheat sheet. This keeps the text without a distinct background and no margins to inset it from the headers.
A more complete fix might be to undo the forced dark mode for code blocks and then make all code block respect the theme and restyle the cheat sheet.
Note: There is no side fade on the blocks that have the horizontal scroll, so that's less clear, but it needs more spacing refinement to give it the horizontal space to accommodate the fades. Hence, minimal fix.
💥 Impact
🌐 References
Closes #1447
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.