chore: bump golang.org/x/crypto to v0.54.0 to clear SSH advisories - #35
Merged
Conversation
The gRPC-Go v1.83.0 bump pulled golang.org/x/crypto from v0.44.0 up to v0.51.0, which carries six advisories in golang.org/x/crypto/ssh: GO-2026-5033, GO-2026-5023, GO-2026-5021, GO-2026-5020, GO-2026-5019, GO-2026-5018 All are fixed in v0.52.0. dgrpc never imports crypto/ssh, so none of these were reachable from our code, but the module requirement alone trips dependency scanners (including the dependency-review workflow). Bump to the current latest v0.54.0, which carries along the companion golang.org/x modules: net v0.55.0 -> v0.56.0, sync v0.20.0 -> v0.22.0, sys v0.45.0 -> v0.47.0, term v0.43.0 -> v0.45.0, text v0.37.0 -> v0.40.0. govulncheck now reports no x/crypto/ssh findings. The remaining findings come from the Go toolchain itself, not from this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gRPC-Go v1.83.0 bump (#33) pulled
golang.org/x/cryptofrom v0.44.0 up to v0.51.0, which carries six advisories ingolang.org/x/crypto/ssh. This bumps it to v0.54.0 to clear them.golang.org/x/crypto/ssh/agentVerifiedPublicKeyCallbackpermissions skip enforcement@revokedstatus inknownhostsAll six are fixed in v0.52.0.
Reachability:
dgrpcnever importscrypto/ssh, so none of these were reachable from our code —govulncheckreported them at module level only, never as called paths. The module requirement alone is what trips dependency scanners, including thedependency-reviewworkflow added in 491979d.Changes
Bumped to the current latest v0.54.0 rather than the minimum v0.52.0. This carries along the companion
golang.org/xmodules:golang.org/x/cryptov0.51.0 → v0.54.0golang.org/x/netv0.55.0 → v0.56.0golang.org/x/syncv0.20.0 → v0.22.0golang.org/x/sysv0.45.0 → v0.47.0golang.org/x/termv0.43.0 → v0.45.0golang.org/x/textv0.37.0 → v0.40.0No source changes — dependency manifests and
CHANGELOG.mdonly.Verification
go test ./...— all packages passgo build ./...— cleangovulncheck ./...— nox/crypto/sshfindings remainNotes
Two things this PR deliberately does not address:
GO-2026-5932(golang.org/x/crypto/openpgpis unmaintained) still reports against v0.54.0. It is markedFixed in: N/A— there is no patched version, and we do not importopenpgp.govulncheckfindings are all Go standard library, attributed to the local toolchain (go1.25.4) rather than to anything in this module. They resolve by upgrading the Go toolchain used to build, not by changinggo.mod.