Skip to content

Match allowed link hosts on a literal dot #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwizla merged 1 commit into from
Aug 26, 2026
Merged

Match allowed link hosts on a literal dot #3410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/scripts/automerge/check-no-external-links.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ set -euo pipefail
source "$(dirname "${BASH_SOURCE[0]}")/lib.sh"

# Extended regex of hosts that do not count as external.
ALLOWED_HOSTS="${AUTOMERGE_ALLOWED_LINK_HOSTS:-strapi\.io|docs\.strapi\.io|github\.com/strapi|market\.strapi\.io|cloud\.strapi\.io}"
#
# Dots are written [.] rather than \. on purpose. This string reaches awk through
# -v, where a backslash is a STRING escape, not a regex one: awk consumes it and
# gawk warns "escape sequence \. treated as plain .". The dot then matches any
# character, so `strapiXio.evil.com` would have been accepted as an allowed host.
# [.] survives -v untouched and means exactly one literal dot.
ALLOWED_HOSTS="${AUTOMERGE_ALLOWED_LINK_HOSTS:-strapi[.]io|docs[.]strapi[.]io|github[.]com/strapi|market[.]strapi[.]io|cloud[.]strapi[.]io}"

PR="${1:-}"
require_pr_number "$PR"
Expand Down
Loading