Allow evaluating a PR's eligibility manually - #3406
Merged
Merged
Conversation
The workflow only ran on pull_request events, so an existing PR could not be evaluated without editing it first. workflow_dispatch takes a PR number, skips the quiet period since a manual run is already deliberate, and stays silent on Slack because a veto line for a PR being looked at is noise.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
Collaborator
Author
|
LGTM, let's merge so we can assess PR 3366 in prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-merge eligibility workflow only listened to pull_request events, so an already-open PR could not be evaluated without editing it to trigger one. #3366 is exactly that case: a real pipeline PR that predates the workflow and has no way of being assessed.
workflow_dispatchnow takes apr_numberinput, and every reference to the PR number falls back to itFollows #3401