[sync-review] Fix upstream manifest-synced paths blocking stranske/Ready#573

[stranske]

Why

Consumer sync PR stranske/Ready#573 (also stranske/Doc-Lineage#26) has unresolved bot review threads on two manifest-synced paths whose upstream sources live in Workflows:

1. templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml — runner dispatch debounce treats any completed record on the same (pr, head_sha, provider) as productive, but Keepalive runner-dispatch debounce latches on a zero-output run (duplicate-completed deadlock) #3433 requires counting task deltas; a no-commit run that advances task state must not burn the debounce key.
2. tools/embedding_provider.py — blank inputs are filtered out of the returned vector list, breaking the one-vector-per-input contract exercised by consumer tests.

Scope

Fix both upstream sources in Workflows main so maint-68 sync regeneration outdates the consumer review threads.

Non-Goals

• Implementing the full Keepalive runner-dispatch debounce latches on a zero-output run (duplicate-completed deadlock) #3433 keepalive-loop fix here; only the scripts/runner_lib/core.py debounce productivity semantics that the gate-followups workflow calls via python -m scripts.runner_lib should-dispatch.
• Changing consumer PR bodies or merging consumer sync PRs from this issue.

Tasks

• In scripts/runner_lib/core.py, extend should_dispatch / record_completion so a completed dispatch is only debounced when it was productive (head commit changed or tasks_completed_delta > 0 recorded in the completion payload).
• Add a regression in tests/scripts/test_runner_lib_dispatch.py (or existing runner_lib test module) proving a completed record with zero commits and zero task delta does not block the next should_dispatch for the same head.
• In tools/embedding_provider.py, preserve index-aligned output: return one vector per input position (zero/blank-safe vector for empty strings) instead of filtering blanks out of items at lines 155 and 214.
• Add test_embed_preserves_index_alignment_with_blank_inputs to tests/tools/test_embedding_provider.py asserting five inputs including blanks yield five vectors.
• Run ./scripts/sync_templates.sh so templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml and synced tool copies match.

Acceptance Criteria

• pytest tests/scripts/test_runner_lib_dispatch.py tests/tools/test_embedding_provider.py -q passes, including both new tests named above.
• ./scripts/sync_templates.sh exits 0 with git status --porcelain templates/consumer-repo empty on an already-synced tree.
• Deliberate-break gate: restore blank-filtering in tools/embedding_provider.py → the index-alignment test must FAIL → revert.

Implementation Notes

Review threads: stranske/Ready#573 on tools/embedding_provider.py and .github/workflows/agents-81-gate-followups.yml. Gate-followups calls debounce at templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml:398-402 via python -m scripts.runner_lib should-dispatch.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 3 cited path(s) do not exist yet: .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/tools/embedding_provider.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 1 of 3).

[stranske]

Upstream sync review debt

Consumer delivery PR: stranske/Doc-Lineage#26

Manifest-synced paths with unresolved bot review threads:

• consumer .github/workflows/agents-81-gate-followups.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml
• consumer tools/discover_model_catalog.py → source stranske/Workflows/tools/discover_model_catalog.py

Fix these paths in Workflows main so the next sync regeneration outdates the consumer threads.

[agents-workflows-bot]

🏷️ Label Suggestions

Based on the issue content, these labels might be relevant:

• agents (95% confidence)
• agents:keepalive (95% confidence)
• consumer-sync (95% confidence)
• python (95% confidence)
• status: ready (95% confidence)

How to use these suggestions

• Click the label name in the sidebar to add it
• Or use the GitHub CLI: gh issue edit 3449 --add-label "label-name"

---

Auto-generated by label matcher

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 3 cited path(s) do not exist yet: `.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/tools/embedding_provider.py` — expected when a task creates them; check for typos otherwise.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 3 cited path(s) do not exist yet: .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/tools/embedding_provider.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 2 of 3).

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 3 cited path(s) do not exist yet: `.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/tools/embedding_provider.py` — expected when a task creates them; check for typos otherwise.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 3 cited path(s) do not exist yet: .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/tools/embedding_provider.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 3 of 3).

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 3 cited path(s) do not exist yet: `.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/tools/embedding_provider.py` — expected when a task creates them; check for typos otherwise.