[sync-review] Fix upstream manifest-synced paths blocking stranske/Pension-Data#899

[stranske]

Why

Consumer sync PR stranske/Pension-Data#899 (also stranske/Manager-Mosaic#23) carries an unresolved CodeRabbit thread on tools/discover_model_catalog.py. bool is a subclass of int, so a malformed catalog value such as created_at: true passes isinstance(value, (int, float)) in _parse_timestamp, becomes a 1970 timestamp, and catalog_diff can hide a genuinely new model as historical.

Scope

Fix timestamp parsing in tools/discover_model_catalog.py at the Workflows upstream source so the next maint-68 sync regeneration outdates the consumer review thread.

Non-Goals

• Changing consumer PRs directly; the fix lands in Workflows main and propagates via sync.
• Altering catalog selection policy beyond rejecting non-numeric boolean timestamps.

Tasks

• In tools/discover_model_catalog.py, update _parse_timestamp to reject bool values before the numeric branch (e.g. isinstance(value, bool) guard or type(value) is int check).
• Add test_parse_timestamp_rejects_bool_created_at to tests/tools/test_discover_model_catalog.py proving created_at: true in a GitHub Models payload is ignored and does not produce a 1970 CatalogModel.
• Run ./scripts/sync_templates.sh if the consumer template copy of tools/discover_model_catalog.py is manifest-synced.

Acceptance Criteria

• pytest tests/tools/test_discover_model_catalog.py -q passes, including the new bool-rejection test.
• Deliberate-break gate: remove the bool guard in _parse_timestamp → the new test must FAIL → revert.

Implementation Notes

Review thread: stranske/Pension-Data#899 on tools/discover_model_catalog.py. Upstream source verified at tools/discover_model_catalog.py:48-58 in this repository.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 1 cited path(s) do not exist yet: stranske/Workflows/tools/discover_model_catalog.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 1 of 3).

[agents-workflows-bot]

🏷️ Label Suggestions

Based on the issue content, these labels might be relevant:

• consumer-sync (95% confidence)
• data (95% confidence)
• model-selection (95% confidence)
• sync (95% confidence)
• test (95% confidence)

How to use these suggestions

• Click the label name in the sidebar to add it
• Or use the GitHub CLI: gh issue edit 3448 --add-label "label-name"

---

Auto-generated by label matcher

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 1 cited path(s) do not exist yet: `stranske/Workflows/tools/discover_model_catalog.py` — expected when a task creates them; check for typos otherwise.

[stranske]

Upstream sync review debt

Consumer delivery PR: stranske/Manager-Mosaic#23

Manifest-synced paths with unresolved bot review threads:

• consumer tools/discover_model_catalog.py → source stranske/Workflows/tools/discover_model_catalog.py

Fix these paths in Workflows main so the next sync regeneration outdates the consumer threads.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 1 cited path(s) do not exist yet: stranske/Workflows/tools/discover_model_catalog.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 2 of 3).

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 1 cited path(s) do not exist yet: `stranske/Workflows/tools/discover_model_catalog.py` — expected when a task creates them; check for typos otherwise.

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

Missing required sections: Tasks, Acceptance Criteria

Advisory:

• 1 cited path(s) do not exist yet: stranske/Workflows/tools/discover_model_catalog.py — expected when a task creates them; check for typos otherwise.

Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

Dispatched the Agents Issue Optimizer format phase (attempt 3 of 3).

[github-actions]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

Format validation report:

This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.

- `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
- `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.

_Advisory:_
- 1 cited path(s) do not exist yet: `stranske/Workflows/tools/discover_model_catalog.py` — expected when a task creates them; check for typos otherwise.