You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Post-merge verification (D4-verify-merged-2026-09-16T02) of #1678 (merge 25e497f834e10333b7f7f830bbe8c57c3ea7b974) against #1669 found junction-table logic and SQLite tests landed, but Postgres acceptance is opt-in only.
Migration alembic/versions/022_document_managers.py, embeddings.py association inserts, and SQLite tests are present in squash diff.
Wire the existing Postgres service in .github/workflows/ci.yml to run document-manager association tests without manual env setup.
Tasks
In .github/workflows/ci.yml, extend the postgres-integration job to export DOCUMENT_TEST_POSTGRES_URL from the existing MGRDB_PG_TEST_URL service and run pytest tests/test_document_managers_migration.py -k document_association -v.
In tests/test_embeddings.py::test_shared_document_preserves_each_manager, ensure the shared-document regression still passes on SQLite and is included in the Gate pytest selection alongside tests/test_document_managers_migration.py.
Acceptance Criteria
Named test: pytest tests/test_document_managers_migration.py -k document_association passes on Gate with Postgres available (no skip of postgres leg).
Deliberate-break → revert: disable document_managers insert in embeddings.py → shared-document test FAILS on Postgres → restore → passes.
Why (verified evidence)
Post-merge verification (D4-verify-merged-2026-09-16T02) of #1678 (merge
25e497f834e10333b7f7f830bbe8c57c3ea7b974) against #1669 found junction-table logic and SQLite tests landed, but Postgres acceptance is opt-in only.alembic/versions/022_document_managers.py,embeddings.pyassociation inserts, and SQLite tests are present in squash diff.tests/test_document_managers_migration.pyPostgres leg usespytest.skipunlessDOCUMENT_TEST_POSTGRES_URLis set — issue Preserve manager associations when document content is deduplicated #1669 acceptance requires disposable Postgres verification in CI, not skip-by-default.Scope
Wire the existing Postgres service in
.github/workflows/ci.ymlto run document-manager association tests without manual env setup.Tasks
.github/workflows/ci.yml, extend thepostgres-integrationjob to exportDOCUMENT_TEST_POSTGRES_URLfrom the existingMGRDB_PG_TEST_URLservice and runpytest tests/test_document_managers_migration.py -k document_association -v.tests/test_embeddings.py::test_shared_document_preserves_each_manager, ensure the shared-document regression still passes on SQLite and is included in the Gate pytest selection alongsidetests/test_document_managers_migration.py.Acceptance Criteria
pytest tests/test_document_managers_migration.py -k document_associationpasses on Gate with Postgres available (no skip of postgres leg).document_managersinsert inembeddings.py→ shared-document test FAILS on Postgres → restore → passes.Non-Goals
Surfaced by D4-verify-merged-2026-09-16T02; verified against squash diff
Manager-Database-1678.diffand issue #1669. Related: #1669, merged PR #1678.