Telemetry: Add sidebar filter telemetry for change detection#34482
Open
valentinpalkovic wants to merge 10 commits intonextfrom
Open
Telemetry: Add sidebar filter telemetry for change detection#34482valentinpalkovic wants to merge 10 commits intonextfrom
valentinpalkovic wants to merge 10 commits intonextfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit 9a9e290
☁️ Nx Cloud last updated this comment at |
12 tasks
… globals exports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
In mobile mode, clicking a story calls setMobileMenuOpen(false), which starts a 300ms exit transition on the Modal. After it completes, children are unmounted (unmountOnExit: true). On slow sandboxes like Angular webpack, by the time waitForURL resolves the tree is already unmounted, so the storyLink locator finds nothing and toHaveAttribute fails with "element(s) not found". URL verification already confirms correct navigation, so we safely skip the attribute check when the element is gone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: valentinpalkovic <5889929+valentinpalkovic@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added a
sidebar-filtertelemetry event to track usage of built-in tag filters (_docs,_play,_test) and change detection status filters (new,modified,affected) in the sidebar.The event fires in two scenarios:
Each event includes the full active filter state and per-filter story counts. User-defined tag filters are explicitly excluded from telemetry.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
.storybook/main.ts:features: { changeDetection: true }yarn task --task sandbox --start-from auto --template react-vite/default-tssidebarFilterChangedevent is emitted on the channel?statuses=status-value%3AnewURL param → verify a URL-triggered telemetry event fires once on loadDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>