Yaml files cron timer eol - #507
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 99.10% 98.99% -0.11%
==========================================
Files 112 113 +1
Lines 2787 2790 +3
Branches 340 340
==========================================
Hits 2762 2762
- Misses 22 25 +3
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
We are going to trigger the hygiene automation for EOL VMs from a cron (st2 cronTimer). Here we create the cron YAML config file. In this config we set the OS names and versions we want to automation to pay attention to, instead of hardcoding it in the code.
Here we create the cron YAML config file for the ACTION. It must include the parameters from the cron YAML file.
23cb9a0 to
09b7ef3
Compare
| type: core.st2.CronTimer | ||
| parameters: | ||
| timezone: "Europe/London" | ||
| day_of_week: mon,tue,wed,thu,fri |
There was a problem hiding this comment.
I don't think this need to run daily, as not much is going to change day to day regarding OS version, maybe once a week?
There was a problem hiding this comment.
Hmm... The point was to detect them as soon as possible, but w/o going too fast. I think I will add this question to the others for David F.
There was a problem hiding this comment.
I think daily is fine. ST2 is supposed to be an automation tool so let it automate away.
Skeleton for the new hygiene workflow. Here we create the yaml files and a fake implementation of the actual automation code.