revert back to using a flag to set if conn object should be created - #504
Open
anish-mudaraddi wants to merge 1 commit into
Open
revert back to using a flag to set if conn object should be created#504anish-mudaraddi wants to merge 1 commit into
anish-mudaraddi wants to merge 1 commit into
Conversation
anish-mudaraddi
force-pushed
the
revert-requires-openstack
branch
from
August 19, 2026 14:03
609051a to
29386c8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 99.19% 99.19% -0.01%
==========================================
Files 112 112
Lines 2723 2717 -6
Branches 336 336
==========================================
- Hits 2701 2695 -6
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anish-mudaraddi
force-pushed
the
revert-requires-openstack
branch
from
August 19, 2026 14:12
29386c8 to
e1f0f37
Compare
jose-caballero
previously approved these changes
Aug 20, 2026
anish-mudaraddi
force-pushed
the
revert-requires-openstack
branch
from
August 21, 2026 11:31
e1f0f37 to
4855b78
Compare
anish-mudaraddi
force-pushed
the
revert-requires-openstack
branch
from
August 21, 2026 11:35
4855b78 to
3173be2
Compare
azahmd
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to remove the need for this flag in #491 and #501 but it introduced too many bugs
renamed "requires_openstack" to "create_openstack_connection" to make it more clear and add comments