BUG - os_builders: Fix rename_images.sh - #198
Merged
Merged
Conversation
AQ images are not being set public and named to the production name. This commit fixes that bug. It was due to the `openstack image set --public --name` only being in the else part of the statement. So I have separated the --public and --name into 2 commands. We always want to update the name but we don't always want to set the image to public. For example, the aq images are shared. As this change does not affect the image configuration I am not going to update the changelog.
khalford
force-pushed
the
fix_rename_script
branch
from
August 25, 2026 14:16
81a71c9 to
faa63aa
Compare
jose-caballero
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AQ images are not being set public and named to the production name. This commit fixes that bug. It was due to the
openstack image set --public --nameonly being in the else part of the statement. So I have separated the --public and --name into 2 commands. We always want to update the name but we don't always want to set the image to public. For example, the aq images are shared.As this change does not affect the image
configuration I am not going to update the changelog.