Fixes lost comments on interface blocks with limitations due to fparser output. - #3542
Open
LonelyCat124 wants to merge 4 commits into
Open
Fixes lost comments on interface blocks with limitations due to fparser output.#3542LonelyCat124 wants to merge 4 commits into
LonelyCat124 wants to merge 4 commits into
Conversation
LonelyCat124
marked this pull request as ready for review
August 5, 2026 13:17
Collaborator
Author
|
@sergisiso @arporter This is ready for a look now - there are limitations due to fparser that are discussed in comments. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3542 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 55579 55611 +32
=========================================
+ Hits 55579 55611 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fparser issue 521: stfc/fparser#521
Fixes lost comments missed in the last PR. Still WIP as I'm now getting a duplicated interface for some reason.