Skip to content

(towards #1995) Update source file headers - #3508

Open
sergisiso wants to merge 17 commits into
masterfrom
1995_update_headers
Open

(towards #1995) Update source file headers#3508
sergisiso wants to merge 17 commits into
masterfrom
1995_update_headers

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator
  • Updated header of python, fortran and rst files to use SPDX and refer to root directory license
  • Consolidated authors of previous headers and git log into AUTHORS.md

I haven't done other file types yet, e.g. shell, Makefiles, md. But GH is already struggling with the size of this PR, so it will come in a separate one.

@sergisiso
sergisiso requested a review from arporter July 28, 2026 13:46
@sergisiso sergisiso self-assigned this Jul 28, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Ready for review

Sorry for the length of this very repetitive PR. The following do not have the main header different_header.txt (but even this are repetitive)

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d49fe29) to head (f5a1e6e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines        55579     55579           
=========================================
  Hits         55579     55579           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub have clearly done some work to improve their handling of large PRs - this wasn't too bad. It's mostly inconsistencies in the dates but I see there are quite a few brand-new __init__.py files that I don't think are needed?

Comment thread examples/lfric/code/matrix_vector_kernel_mod.F90
Comment thread examples/lfric/eg10/prolong_kernel_mod.F90
Comment thread examples/nemo/code/tra_adv.F90 Outdated
Comment thread examples/nemo/code/traldf_iso.F90 Outdated
Comment thread examples/nemo/eg4/tra_adv_compute.F90 Outdated
Comment thread tutorial/practicals/LFRic/building_code/gungho_lib/write_methods_mod.f90 Outdated
Comment thread AUTHORS.md Outdated
Comment thread AUTHORS.md Outdated
Comment thread AUTHORS.md Outdated
Comment thread AUTHORS.md Outdated
@arporter

Copy link
Copy Markdown
Member

Also, since we're touching the surrounding comments, we should probably update the link to the SRS and replace it with github. We can also remove the (dead) link to the wiki page that used to be on Puma.

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Addressed the comments and also removed the double-spacing the some copyright texts

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter This is ready for another review

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Almost there now - just a couple of things slipped through.

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Ready for another look

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergi. All good now but I guess I should run the ITs to check.

@arporter
arporter deployed to integration August 6, 2026 13:06 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants