(towards #1995) Update source file headers - #3508
Conversation
|
@arporter Ready for review Sorry for the length of this very repetitive PR. The following do not have the main header different_header.txt (but even this are repetitive) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3508 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 55579 55579
=========================================
Hits 55579 55579 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arporter
left a comment
There was a problem hiding this comment.
GitHub have clearly done some work to improve their handling of large PRs - this wasn't too bad. It's mostly inconsistencies in the dates but I see there are quite a few brand-new __init__.py files that I don't think are needed?
|
Also, since we're touching the surrounding comments, we should probably update the link to the SRS and replace it with github. We can also remove the (dead) link to the wiki page that used to be on Puma. |
|
@arporter Addressed the comments and also removed the double-spacing the some copyright texts |
|
@arporter This is ready for another review |
arporter
left a comment
There was a problem hiding this comment.
Good stuff. Almost there now - just a couple of things slipped through.
|
@arporter Ready for another look |
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi. All good now but I guess I should run the ITs to check.
I haven't done other file types yet, e.g. shell, Makefiles, md. But GH is already struggling with the size of this PR, so it will come in a separate one.