chore(deps): bump lucide-react from 1.18.0 to 1.21.0 in /src/StackAlchemist.Web#169
Merged
stevenfackley merged 1 commit intoJun 22, 2026
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
stevenfackley
added a commit
that referenced
this pull request
Jun 22, 2026
…-Library getByDisplayValue (#171) * fix(web): use Playwright getByPlaceholder in advanced-draft smoke (repairs red main CI) advanced-draft-persistence.spec.ts called page.getByDisplayValue(), a Testing-Library API that does not exist on Playwright's Page — every smoke run threw "TypeError: page.getByDisplayValue is not a function", failing the E2E Smoke (Demo Mode) + Quality Gate jobs and reddening main since 93cb6b2 (#142). Locate the single entity-name input by its placeholder ("EntityName") and assert state with toHaveValue, matching how the RTL component test already queries it. Unblocks Dependabot #169/#170. * fix(web): clear smoke draft storage once, not on every reload beforeEach used page.addInitScript(() => localStorage.clear()), which re-runs on EVERY navigation — including the page.reload() the persistence tests depend on — wiping the saved draft mid-test. So even after the getByDisplayValue fix, the "survives a reload" assertion could never pass (input reverted to default). Clear storage once after landing on the origin instead. Verified locally against a demo-mode server: all 3 advanced-draft smoke tests pass. * fix(web): assert focus-trap by containment, not innerText text match The "Tab stays trapped" smoke test compared the focused element's innerText (CSS text-transform: uppercase -> "✦ HELP ME WRITE THIS") against the dialog's textContent (raw "✦ Help me write this") via toContainText, which is case- sensitive — so it never matched once focus reached the uppercased CTA button. Assert dialog.contains(activeElement) directly, which is what the focus trap actually guarantees. Verified locally: all personalization + advanced-draft smoke tests pass.
Owner
|
@dependabot rebase |
Bumps [lucide-react](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react) from 1.18.0 to 1.21.0. - [Release notes](https://github.com/lucide-icons/lucide/releases) - [Commits](https://github.com/lucide-icons/lucide/commits/1.21.0/packages/lucide-react) --- updated-dependencies: - dependency-name: lucide-react dependency-version: 1.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/src/StackAlchemist.Web/lucide-react-1.21.0
branch
from
7ed14ee to
b99b650
Compare
stevenfackley
deleted the
dependabot/npm_and_yarn/src/StackAlchemist.Web/lucide-react-1.21.0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps lucide-react from 1.18.0 to 1.21.0.
Release notes
Sourced from lucide-react's releases.
... (truncated)
Commits
5ff536eci(release.yml): Fix workflow and removeversionscripts in package scripts...