Skip to content

fix: default RevertGithubDNSExperiment to true when flags can't be fetched - #510

Merged
h0x0er merged 2 commits into
mainfrom
jatin/dns-revert-default-main
Nov 3, 2026
Merged

h0x0er merged 2 commits into
mainfrom
jatin/dns-revert-default-main

Conversation

@h0x0er

@h0x0er h0x0er commented Nov 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Default RevertGithubDNSExperiment to true when global feature flags can't be fetched, so the GitHub DNS experiment revert always runs on failure.
  • Adds a defaultGlobalFeatureFlags() helper, used on every failure path in getGlobalFeatureFlags() and as the manager's initial and uninitialized defaults.
  • A successful response is still decoded into a zero-value struct, so the server can still turn the flag off.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.52%. Comparing base (f4b6651) to head (b043325).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
apiclient.go 0.00% 5 Missing ⚠️
global_feature_flags.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   63.07%   70.52%   +7.44%     
==========================================
  Files          20       21       +1     
  Lines        2402     1730     -672     
==========================================
- Hits         1515     1220     -295     
+ Misses        726      510     -216     
+ Partials      161        0     -161     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h0x0er
h0x0er merged commit 1ff3fa6 into main Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants