RPCv1 XDR views: migrate getEvents

[cjonas9]

What

Moves RPCv1 getEvents onto XDR views. The filter loop and the response renderer both paid for Unmarshals of every scanned xdr.DiagnosticEvent; now nothing in the query path decodes an event.

Handler-local matcher (methods/event_filter.go): a view port of the SDK's GetEventsRequest.Matches. Filters compile once per request into wire-form comparison values (decoded contract ids, marshaled topic segments, a trailing ** as an arity flag) and match against the raw bytes the view hands back. rpcv2's stores/event and its v1Filters shim are untouched.

RPCv1 query path:

• store.ScanFunction -> store.ViewScanFunction: takes xdr.DiagnosticEventView, returns (bool, error).
• sqlitedb.GetEvents reads rows as sql.RawBytes and wraps them as views; scanner errors abort the scan.
• methods/get_events.go locates each event's fields once via Fields(), matches, and renders matches inside the scan callback. Topics are read only after type and contract id pass. The callback's own error is captured and returned unchanged, as getTransactions does, so a render failure keeps its system error code.

Shared renderer: methods.EventInfoFromView replaces both eventInfoForEvent and the rpcv2 eventInfoV2 body. ev.Fields() and v0.Fields() locate type, contract id, topics and data in one pass each and return trimmed views, so their bytes are used directly with no Raw() re-walks. The type name comes from a switch instead of the SDK's per-call map. rpcv2 wraps it and rejects non contract/system types on the returned name. Wire output is byte-identical.

Why

See epic #732.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Migrates RPCv1 event filtering and response generation to zero-copy XDR views while sharing matching logic with RPCv2.

Changes:

• Adds shared view-based event filter compilation and matching.
• Updates SQLite scanning and RPC response construction to use XDR views.
• Updates RPCv2 integration, tests, and SQLite dependency.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
go.mod	Updates SQLite dependency.
go.sum	Updates SQLite checksums.
internal/store/event.go	Defines view-based scanner API.
internal/store/event_match.go	Adds shared event matching logic.
rpcv2/stores/event/match.go	Reuses shared matcher types and functions.
rpcv2/stores/event/match_test.go	Updates matcher tests.
rpcv2/stores/event/extract_test.go	Adapts extraction tests to views.
rpcv2/eventsapi/get_events_v2.go	Builds responses from event views.
rpcv2/eventsapi/get_events_v1.go	Delegates shared filtering and conversion.
rpcv1/sqlitedb/migration_test.go	Updates scanner callback signature.
rpcv1/sqlitedb/event.go	Scans stored events as views.
rpcv1/sqlitedb/event_test.go	Updates view-based scanner tests.
methods/get_events.go	Uses shared filters and view-based responses.

Note

Copilot is running an experiment and ran this review at Balanced.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Note

Copilot is running an experiment and ran this review at Balanced.

[Copilot]

🟡 Changes recommended

The hot response path lost its page-size preallocation and now repeatedly reallocates and copies results.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 12/12 changed files
• Comments generated: 1
• Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.