Conversation
Opening a packfile allocated its offsets table, its index decode scratch and its read buffers afresh every time, and cold reads open packfiles on every request. The open path now takes these from pools and returns them on every exit, failed opens included. A reader hands its offsets table back when it closes, once no read is still using it. A buffer too large for its pool is dropped rather than kept, and each drop is counted and exported as pooled_buffer_cap_skips_total. The count should stay at zero; any other value means a cap wants raising. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QHnF5BhsuoxpWxGmatQzmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pooled_buffer_cap_skips_total.Why
Cold reads open packfiles on every request, and each open allocated these buffers afresh.
Split out of #968.
Known limitations
pooled_buffer_cap_skips_totalshould stay at zero; any other value means a pool's cap wants raising.🤖 Generated with Claude Code