Skip to content

feat: add stats/incr/nanmme - #9460

Merged
Planeshifter merged 11 commits into
stdlib-js:developfrom
kanikasharma-18:fix-nanmme
Jul 21, 2026
Merged

feat: add stats/incr/nanmme#9460
Planeshifter merged 11 commits into
stdlib-js:developfrom
kanikasharma-18:fix-nanmme

Conversation

@kanikasharma-18

@kanikasharma-18 kanikasharma-18 commented Dec 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #5587

Description

What is the purpose of this pull request?

This pull request:

  • Implement NaN handling in the nanmme accumulator function in stats/incr/nanmme.

  • Ensures that NaN inputs are ignored without breaking the incremental moving mean error computation.

  • Passes all existing test cases and maintains backward compatibility.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
results of tests -

Screenshot 2025-12-31 at 7 33 24 PM

results of benchmark -

Screenshot 2025-12-31 at 7 34 15 PM

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

@stdlib-js/reviewers

@kanikasharma-18
fix(stats/incr/nanmme): handle NaN in nanmme accumulator
b2bc7a5 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 31, 2025
@stdlib-bot

stdlib-bot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 31, 2025
@kanikasharma-18
fix(stats/incr/nanmme): fix review changes
c4b37bf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18

kanikasharma-18 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

@nakul-krishnakumar This PR is ready for review.

@kanikasharma-18
fix: review changes
1322ea8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title feat: add stats/incr/nanmme feat: add stats/incr/nanmme Jan 11, 2026
@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Jan 18, 2026
@kanikasharma-18
fix: changes required
f909c9a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
fix: fixed changes required
8315648 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18
fix: review changes
40e6837 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kanikasharma-18

kanikasharma-18 commented Jan 18, 2026

Copy link
Copy Markdown
Contributor Author

@Planeshifter I have made the required changes sir. Please review my PR.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 25, 2026
@kanikasharma-18

kanikasharma-18 commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

@Planeshifter @nakul-krishnakumar @kgryte
Please review this PR.

Planeshifter
Planeshifter requested changes Mar 9, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of feedback.

Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/test/test.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/test/test.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/package.json Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/examples/index.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmme/docs/repl.txt Resolved
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 9, 2026
This was referenced Jul 18, 2026
Closed
Closed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Jul 19, 2026
@Planeshifter
Planeshifter requested a review from a team July 20, 2026 20:30
@Planeshifter

Planeshifter commented Jul 20, 2026

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. Needs Review A pull request which needs code review. labels Jul 20, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 20, 2026
Planeshifter
Planeshifter approved these changes Jul 21, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanikasharma-18 for opening this PR and @nakul-krishnakumar for review!

@stdlib-bot

stdlib-bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmme`

PR-URL: https://github.com/stdlib-js/stdlib/pull/9460
Closes: https://github.com/stdlib-js/stdlib/issues/5587

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 21, 2026
@Planeshifter
Planeshifter merged commit e6abaec into stdlib-js:develop Jul 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nakul-krishnakumar nakul-krishnakumar nakul-krishnakumar left review comments
@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmme

4 participants

@kanikasharma-18 @stdlib-bot @Planeshifter @nakul-krishnakumar