Repository navigation
feat: add symbol/to-string-tag - #8491
Open
kaushal-kumar-it wants to merge 8 commits into
Open
kaushal-kumar-it wants to merge 8 commits into
kaushal-kumar-it wants to merge 8 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Nov 18, 2025
| * | ||
| * ## Notes | ||
| * | ||
| * - This symbol is used to determine whether a constructor object recognizes an object as its instance. |
kgryte
reviewed
Nov 18, 2025
| // EXPORTS // | ||
|
|
||
| /** | ||
| * Has instance symbol. |
kgryte
reviewed
Nov 18, 2025
| }; | ||
| } | ||
|
|
||
| function toStringTag( instance ) { |
Member
There was a problem hiding this comment.
This example needs to be updated to match the README.
kgryte
reviewed
Nov 18, 2025
| * }; | ||
| * }; | ||
| * | ||
| * ArrayLike[ ToStringTagSymbol ] = isArray; |
Member
There was a problem hiding this comment.
Same thing. This example needs to be updated.
kgryte
reviewed
Nov 18, 2025
| 'use strict'; | ||
|
|
||
| /** | ||
| * Symbol used to determine if a constructor object recognizes an object as its instance. |
kgryte
reviewed
Nov 18, 2025
| * @type {(symbol|null)} | ||
| * | ||
| * @example | ||
| * var isArray = require( '@stdlib/assert/is-array' ); |
kgryte
reviewed
Nov 18, 2025
| { | ||
| "name": "@stdlib/symbol/to-string-tag", | ||
| "version": "0.0.0", | ||
| "description": "Has `Symbol.toStringTag` symbol.", |
symbol/to-string-tag
Contributor
Author
|
@kgryte i have fixed all copy-paste errors pls review it whenever you get time . |
3 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8482
Description
This pull request implements the RFC proposing the addition of the
symbol/to-string-tagpackage.The package is modeled after existing symbol utilities in the repository, including:
symbol/has-instancesymbol/iteratorsymbol/async-iteratorsymbol/is-concat-spreadableThe new package exports
Symbol.toStringTagwhen available in the current environment.Additional implementation details include:
(e.g.,
has-instance→to-string-tag,HasInstanceSymbol→ToStringTagSymbol)Symbol.toStringTagRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR includes descriptive text drafted with the assistance of ChatGPT to ensure that the RFC details and PR documentation are clear and complete. All code changes were written and validated manually.
@stdlib-js/reviewers