[MohannedAhmed67]

…cr/nanmpcorrdist

---

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

• task: lint_filenames status: passed
• task: lint_editorconfig status: passed
• task: lint_markdown status: passed
• task: lint_package_json status: passed
• task: lint_repl_help status: passed
• task: lint_javascript_src status: passed
• task: lint_javascript_cli status: na
• task: lint_javascript_examples status: passed
• task: lint_javascript_tests status: passed
• task: lint_javascript_benchmarks status: passed
• task: lint_python status: na
• task: lint_r status: na
• task: lint_c_src status: na
• task: lint_c_examples status: na
• task: lint_c_benchmarks status: na
• task: lint_c_tests_fixtures status: na
• task: lint_shell status: na
• task: lint_typescript_declarations status: passed
• task: lint_typescript_tests status: passed
• task: lint_license_headers status: passed ---

Resolves #5602.

Description

What is the purpose of this pull request?

This pull request:

• It adds module which is a wrapper around mpcorrdist for handling NaN values. It ignores any NaN values passes in the accumulator

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves #5602

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[stdlib-bot]

Coverage Report

No coverage information available.

[hrshya]

Hey @MohannedAhmed67, thanks for your work on this! I’ve added some comments on the PR.

[MohannedAhmed67]

@hrshya Thank you so much for your valuable comments on my PR !!!
Is there anything else left to be done ?

[hrshya]

Hey @MohannedAhmed67, Good work. Just need some minor updates.

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. :runner: :dash:

## Getting Started

-   Please read our [contributing guidelines][stdlib-contributing] if you haven't already.
-   For development guidance, refer to the [development guide][stdlib-development].

## Next Steps

1.  A project maintainer will approve GitHub Actions workflows for your PR.
2.  All CI checks must pass before your submission can be fully reviewed.
3.  You'll need to address any failures in linting or unit tests.

## Running Tests Locally

You can use `make` to run any of the CI commands locally from the **root directory** of the stdlib repository:

```bash
# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"
```

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our [Gitter channel][stdlib-gitter] to chat with project maintainers and other community members.

We appreciate your contribution!

## Documentation Links

-   [Contributing Guidelines][stdlib-contributing]
-   [Developtment Guide][stdlib-development]
-   [Gitter channel][stdlib-gitter]
-   [make rules for running examples][make-docs-examples]
-   [make rules for running unit tests][make-docs-test]
-   [make rules for running benchmarks][make-docs-benchmark]

[stdlib-contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md
[stdlib-development]: https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/development.md
[stdlib-gitter]: https://gitter.im/stdlib-js/stdlib

[make-docs-examples]: https://github.com/stdlib-js/stdlib/blob/develop/tools/make/lib/examples/README.md
[make-docs-test]: https://github.com/stdlib-js/stdlib/blob/develop/tools/make/lib/test/README.md
[make-docs-benchmark]: https://github.com/stdlib-js/stdlib/blob/develop/tools/make/lib/benchmark/README.md

[MohannedAhmed67]

I have resolved all mentioned and gone through the file to fill all the similar minor issues.
Please check again @hrshya
Thanks in advance.

[MohannedAhmed67]

@hrshya Hello, have you checked the PR this time ?
I need to finish this because I started working on a new one yesterday, and I don't want to open many PRs without approving the current ones.

[MohannedAhmed67]

@kgryte Can I get a review of this PR ?

[hrshya]

Just some minor changes. Rest, the PR looks good!

[MohannedAhmed67]

@hrshya Can you please review it again after the latest edits

[hrshya]

Great work! Time to wait for a maintainer to merge this PR :)

[MohannedAhmed67]

@hrshya Do I need to mention anyone ?

[hrshya]

@hrshya Updates ?

Maintainers must be busy because of the amount of PR they are getting. So the only thing we can do is wait for maintainers to review it and meanwhile you can open new PR's.

[MohannedAhmed67]

@hrshya

[Planeshifter]

Sorry we didn't get to your PR. If you are still interested to bring it over the finish line, I have left a bunch of feedback.

[Planeshifter]

/stdlib merge

[Planeshifter]

/stdlib update-copyright-years

[Planeshifter]

Should be ready after clean-up. Thanks @MohannedAhmed67 and @hrshya!

[stdlib-bot]

PR Commit Message

feat: add `stats/incr/nanmpcorrdist`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6614
Ref: https://github.com/stdlib-js/stdlib/issues/5602

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.