Skip to content

feat: add stats/incr/nanmmeanstdev - #6606

Merged
Planeshifter merged 15 commits into
stdlib-js:developfrom
saad-imran-dev:feat/nanmmeanstdev
Jul 19, 2026
Merged

Planeshifter merged 15 commits into
stdlib-js:developfrom
saad-imran-dev:feat/nanmmeanstdev

Conversation

@saad-imran-dev

Copy link
Copy Markdown
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #5591

Description

What is the purpose of this pull request?

This pull request:

  • It adds module which is a wrapper around mmeanstdev for handling NaN values. It ignores any NaN values passes in the accumulator

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 8, 2025
@stdlib-bot

stdlib-bot commented Apr 8, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmeanstdev $\\color{green}144/144$
$\\color{green}+0.00\\%$
$\\color{green}10/10$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}144/144$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 2, 2025
@ShabiShett07

Copy link
Copy Markdown
Contributor

@saad-imran-dev, please update your pr title to:

feat: add `stats/incr/nanmmeanstdev`

to pass the pr title check.

@saad-imran-dev saad-imran-dev changed the title Feat: add stats/incr/nanmmeanstdev feat: add stats/incr/nanmmeanstdev May 3, 2025
saad-imran-dev and others added 3 commits May 3, 2025 21:20
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
@ShabiShett07

Copy link
Copy Markdown
Contributor

@saad-imran-dev, I think your implementation is missing repl.txt file

Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
saad-imran-dev and others added 3 commits May 6, 2025 10:12
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>
@saad-imran-dev

Copy link
Copy Markdown
Contributor Author

@saad-imran-dev, I think your implementation is missing repl.txt file

@ShabiShett07 I get this error whenever I try to add repl.txt and commit. Not able to resolve this error.

/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/rules/match-signature/lib/main.js:61
                                if ( params[i].multiple !== sigParams[i-skip].multiple ) {

{{alias}}()
    Returns an accumulator function which incrementally computes a moving
    arithmetic mean and corrected sample standard deviation, ignoring
    `NaN` values.

    The `W` parameter defines the number of values over which to compute the
    moving arithmetic mean and corrected sample standard deviation.

    If provided a value, the accumulator function returns updated accumulated
    values. If not provided a value, the accumulator function returns
    the current moving accumulated values.

    As `W` values are needed to fill the window buffer, the first `W-1` returned
    accumulated values are calculated from smaller sample sizes. Until the
    window is full, each returned accumulated value is calculated from all
    provided values.

    Parameters
    ----------
    out: Array|TypedArray (optional)
        Output array.

    W: integer
        Window size.

    Returns
    -------
    acc: Function
        Accumulator function.

    Examples
    --------
    > var accumulator = {{alias}}( 3 );
    > var v = accumulator()
    null
    > v = accumulator( 2.0 )
    [ 2.0, 0.0 ]
    > v = accumulator( -5.0 )
    [ -1.5, ~4.95 ]
    > v = accumulator( NaN )
    [ -1.5, ~4.95 ]
    > v = accumulator( 3.0 )
    [ 0.0, ~4.36 ]
    > v = accumulator( 5.0 )
    [ 1.0, ~5.29 ]
    > v = accumulator( NaN )
    [ 1.0, ~5.29 ]
    > v = accumulator()
    [ 1.0, ~5.29 ]

    See Also
    --------

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some feedback

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_kebab_case
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Planeshifter
Planeshifter requested a review from a team July 19, 2026 05:12
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 19, 2026

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@stdlib-bot

stdlib-bot commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmmeanstdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6606
Closes: https://github.com/stdlib-js/stdlib/issues/5591

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Muhmmad Saad <106260977+saad-imran-dev@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 19, 2026
@Planeshifter
Planeshifter merged commit c33d0b9 into stdlib-js:develop Jul 19, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmmeanstdev

4 participants