Skip to content

feat: add stats/incr/nanmminmaxabs - #6451

Merged
Planeshifter merged 7 commits into
stdlib-js:developfrom
notacountry:develop
Jul 19, 2026
Merged

Planeshifter merged 7 commits into
stdlib-js:developfrom
notacountry:develop

Conversation

@notacountry

Copy link
Copy Markdown
Contributor

Resolves #5597.

Description

What is the purpose of this pull request?

This pull request adds the package @stdlib/stats/incr/nanmminmaxabs. The package is a thin wrapper around @stdlib/stats/incr/mminmaxabs. It wraps a NaN propagating accumulator and skips NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 30, 2025

@stdlib-bot stdlib-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot

stdlib-bot commented Mar 30, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR!

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: notacountry <69242261+notacountry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 9, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Planeshifter
Planeshifter requested a review from a team July 18, 2026 18:22
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib merge

@Planeshifter Planeshifter changed the title Feat/stats incr nanmminmaxabs feat: add stats/incr/nanmminmaxabs Jul 19, 2026
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026
Planeshifter
Planeshifter previously approved these changes Jul 19, 2026

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it. Thanks, @notacountry!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 19, 2026
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Jul 19, 2026
@stdlib-bot

stdlib-bot commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmminmaxabs`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6451
Closes: https://github.com/stdlib-js/stdlib/issues/5597

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Signed-off-by: notacountry <69242261+notacountry@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit 5d500f0 into stdlib-js:develop Jul 19, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmminmaxabs

4 participants