Skip to content

feat: add stats/incr/nanmminmax - #6422

Merged
Planeshifter merged 10 commits into
stdlib-js:developfrom
abhishekblue:feat/incr-nanmminmax
Jul 19, 2026
Merged

feat: add stats/incr/nanmminmax#6422
Planeshifter merged 10 commits into
stdlib-js:developfrom
abhishekblue:feat/incr-nanmminmax

Conversation

@abhishekblue

@abhishekblue abhishekblue commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Resolves #5596

Description

What is the purpose of this pull request?

This pull request:

  • introduces the @stdlib/stats/incr/nanmminmax package, which incrementally computes a harmonic mean, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 28, 2025
@stdlib-bot

stdlib-bot commented Mar 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

hrshya
hrshya reviewed Mar 28, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/README.md Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/README.md Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/README.md Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/benchmark/benchmark.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/docs/types/index.d.ts Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/package.json Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanmminmax/test/test.js Resolved
@abhishekblue abhishekblue mentioned this pull request Mar 31, 2025
Closed
7 tasks done
Planeshifter
Planeshifter reviewed Mar 9, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026
@Planeshifter Planeshifter mentioned this pull request Jul 18, 2026
Closed
@Planeshifter
Planeshifter requested a review from a team July 18, 2026 18:14
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 18, 2026
@Planeshifter

Planeshifter commented Jul 19, 2026

Copy link
Copy Markdown
Member

/stdlib merge

@Planeshifter

Planeshifter commented Jul 19, 2026

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026
@stdlib-bot

stdlib-bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-years

@Planeshifter, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026
Planeshifter
Planeshifter previously approved these changes Jul 19, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up. Thank you, @abhishekblue!

@stdlib-bot

stdlib-bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmminmax`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6422
Closes: https://github.com/stdlib-js/stdlib/issues/5596

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 19, 2026
@Planeshifter
Planeshifter merged commit d369d55 into stdlib-js:develop Jul 19, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes
+1 more reviewer
@hrshya hrshya hrshya left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmminmax

4 participants

@abhishekblue @stdlib-bot @Planeshifter @hrshya