Skip to content

feat: add stats/incr/nanminmaxabs - #6387

Merged
Planeshifter merged 4 commits into
stdlib-js:developfrom
AlyAbdelmoneim:feature/add_nanminmaxabs
Jul 19, 2026
Merged

Planeshifter merged 4 commits into
stdlib-js:developfrom
AlyAbdelmoneim:feature/add_nanminmaxabs

Conversation

@AlyAbdelmoneim

Copy link
Copy Markdown
Contributor

Resolves #5580.

Description

What is the purpose of this pull request?

This pull request:

  • Adds nanminmaxabs, an incremental accumulator for computing the minimum and maximum absolute values while ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 26, 2025
@stdlib-bot

stdlib-bot commented Mar 26, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@AlyAbdelmoneim

Copy link
Copy Markdown
Contributor Author

I'm stuck on linting errors and have been trying to fix them for too long. If anyone wants to take over this issue, you're more than welcome! Any help in figuring out the problem would also be greatly appreciated.

@Planeshifter
Planeshifter requested a review from a team July 18, 2026 18:33
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib merge

@Planeshifter Planeshifter changed the title feat(stats): add nanminmaxabs - incremental min/max absolute values ignoring NaNs feat: add stats/incr/nanminmaxabs Jul 19, 2026
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-years

@Planeshifter, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 19, 2026

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in. Thanks, @AlyAbdelmoneim!

@stdlib-bot

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanminmaxabs`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6387
Closes: https://github.com/stdlib-js/stdlib/issues/5580

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 19, 2026
@Planeshifter
Planeshifter merged commit 2379570 into stdlib-js:develop Jul 19, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanminmaxabs

3 participants