Skip to content

feat: add stats/incr/nanmmean - #6185

Merged
Planeshifter merged 2 commits into
stdlib-js:developfrom
satansin123:feature/adding-nanmmean-package-5588
Jul 17, 2026
Merged

Planeshifter merged 2 commits into
stdlib-js:developfrom
satansin123:feature/adding-nanmmean-package-5588

Conversation

@satansin123

@satansin123 satansin123 commented Mar 19, 2025 •

Copy link
Copy Markdown
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #5588.

Description

What is the purpose of this pull request?

This pull request:

  • Adds the @stdlib/stats/incr/nanmmean package, which computes an incremental mean while handling NaN values by skipping them.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

test -
image

benchmark -
image

examples -
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2025
@stdlib-bot

stdlib-bot commented Mar 19, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmean $\\color{green}148/148$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}148/148$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07

Copy link
Copy Markdown
Contributor

@satansin123, the PR looks good, left some comments to make some changes

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
@Planeshifter
Planeshifter requested a review from a team July 16, 2026 04:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 16, 2026
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jul 16, 2026
@Planeshifter
Planeshifter force-pushed the feature/adding-nanmmean-package-5588 branch 2 times, most recently from a830a41 to fb70016 Compare July 16, 2026 05:11
- Refactor to wrap incrmmean instead of reimplementing
- Fix NaN-before-data bug (was returning 0.0, now returns null)
- Fix typo in repl.txt (ignorning -> ignoring)
- Add NaN handling mention in README description
- Replace randu with uniform/bernoulli in README and examples
- Remove randu import from benchmark, use loop index
- Fix format specifiers in examples/index.js
- Use relative require path in test.js
- Remove backticks from NaN in package.json description
- Update copyright years to 2026
@Planeshifter
Planeshifter force-pushed the feature/adding-nanmmean-package-5588 branch from fb70016 to 4dc019b Compare July 16, 2026 05:27

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to land.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmmean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6185
Closes: https://github.com/stdlib-js/stdlib/issues/5588

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit 9bd9c8f into stdlib-js:develop Jul 17, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmmean

4 participants