Skip to content

feat: add stats/incr/nanewstdev - #6099

Merged
Planeshifter merged 9 commits into
stdlib-js:developfrom
Girish-Garg:feature/nanewstdev
Jul 12, 2026
Merged

feat: add stats/incr/nanewstdev#6099
Planeshifter merged 9 commits into
stdlib-js:developfrom
Girish-Garg:feature/nanewstdev

Conversation

@Girish-Garg

@Girish-Garg Girish-Garg commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

Resolves #5557.

Description

What is the purpose of this pull request?

This pull request:

  • add incremental exponentially weighted standard deviation accumulator by making wrapper over @stdlib/stats/incr/ewstdev main function

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test:
image

Examples:
image

Benchmark:
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 16, 2025
@stdlib-bot

stdlib-bot commented Mar 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanewstdev $\\color{green}133/133$
$\\color{green}+0.00\\%$ 		$\\color{green}7/7$
$\\color{green}+0.00\\%$ 		$\\color{green}2/2$
$\\color{green}+0.00\\%$ 		$\\color{green}133/133$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Girish-Garg Girish-Garg changed the title feat: add incremental exponentially weighted standard deviation accumulator feat: add stats/incr/nanewstdev Apr 23, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 29, 2025
@Girish-Garg

Girish-Garg commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Apr 29, 2025
@Girish-Garg

Girish-Garg commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

@kgryte i think this pr is good enough to merge, if there are any changes required let me know

Planeshifter
Planeshifter requested changes Mar 10, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/incr/nanewstdev/package.json Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanewstdev/README.md Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanewstdev/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanewstdev/examples/index.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanewstdev/README.md Resolved
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
@Planeshifter Planeshifter mentioned this pull request Jul 12, 2026
Closed
@Planeshifter
chore: address review feedback and update copyright years
872b0b0 
- remove backticks around NaN in package.json description
- fix grammar in README notes
- add spaces inside parentheses in main.js
- use %s format specifier for toFixed string output in example
- remove manually populated See Also section
- use `format` for benchmark name string concatenation
@Planeshifter
Planeshifter requested a review from a team July 12, 2026 05:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 12, 2026
@Planeshifter
fix: correct function name and provide required alpha argument in d…
943ddfe 
…octest

The `@module` `@example` used the wrong function name and called the
accumulator factory without the required smoothing factor, causing the
jsdoc-doctest lint to fail.
@Planeshifter

Planeshifter commented Jul 12, 2026

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2026
@Planeshifter
chore: address review feedback
cfc0a78 
- remove unused `isnan` import from README example
- add spaces inside parentheses to satisfy `space-in-parens`
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 12, 2026
@stdlib-bot

stdlib-bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanewstdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6099
Closes: https://github.com/stdlib-js/stdlib/issues/5557

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit 38a69db into stdlib-js:develop Jul 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanewstdev

3 participants

@Girish-Garg @stdlib-bot @Planeshifter