Skip to content

feat: add stats/incr/nanmsumprod - #6098

Merged
Planeshifter merged 7 commits into
stdlib-js:developfrom
Girish-Garg:feature/nanmsumprod
Jul 12, 2026
Merged

Planeshifter merged 7 commits into
stdlib-js:developfrom
Girish-Garg:feature/nanmsumprod

Conversation

@Girish-Garg

Copy link
Copy Markdown
Contributor

Resolves #5613 .

Description

What is the purpose of this pull request?

This pull request:

  • feat: add incrnanmsumprod accumulator for computing moving sum of products while ignoring NaN values by making a wrapper over msumprod function which pre-exisits at stats/incr

test:
image

examples:
image

benchmark:
image

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 16, 2025
@stdlib-bot

stdlib-bot commented Mar 16, 2025 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmsumprod $\\color{green}157/157$
$\\color{green}+0.00\\%$
$\\color{green}8/8$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}157/157$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Girish-Garg Girish-Garg changed the title feat: add incrnanmsumprod accumulator for computing moving sum of products while ignoring NaN values feat: add stats/incr/nansumprod Apr 23, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 29, 2025
@Girish-Garg

Copy link
Copy Markdown
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@kgryte

kgryte commented Apr 30, 2025

Copy link
Copy Markdown
Member

@Girish-Garg You'll want to resolve the CI failures.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 30, 2025
@Girish-Garg Girish-Garg changed the title feat: add stats/incr/nansumprod feat: add stats/incr/nanmsumprod Apr 30, 2025
- use relative require path in test file
- fix bracket spacing in test fixture
- use `format` for benchmark name string concatenation
@Planeshifter
Planeshifter requested a review from a team July 12, 2026 05:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 12, 2026
@Planeshifter

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2026
- rename require variable `incrmsum` to `incrmsumprod` to match wrapped package
- remove unused `isnan` import from README example
- clear hand-populated See Also/related-links sections for auto-population
@stdlib-bot

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanmsumprod`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6098
Closes: https://github.com/stdlib-js/stdlib/issues/5613

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 12, 2026
@Planeshifter
Planeshifter merged commit 1edad6d into stdlib-js:develop Jul 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmsumprod

4 participants