Skip to content

feat: add stats/incr/nanme - #6077

Merged
Planeshifter merged 12 commits into
stdlib-js:developfrom
satansin123:feature/adding-nanme-package-5570
Jul 17, 2026
Merged

feat: add stats/incr/nanme#6077
Planeshifter merged 12 commits into
stdlib-js:developfrom
satansin123:feature/adding-nanme-package-5570

Conversation

@satansin123

@satansin123 satansin123 commented Mar 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #5570 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds the @stdlib/stats/incr/nanme package, which computes an incremental mean error while handling NaN values by skipping them.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

image
image
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 15, 2025
stdlib-bot
stdlib-bot reviewed Mar 15, 2025
View reviewed changes

@stdlib-bot stdlib-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot

stdlib-bot commented Mar 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanme $\\color{green}135/135$
$\\color{green}+0.00\\%$ 		$\\color{green}8/8$
$\\color{green}+0.00\\%$ 		$\\color{green}2/2$
$\\color{green}+0.00\\%$ 		$\\color{green}135/135$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@satansin123 satansin123 changed the title feat(stats): add nanme package feat(stats): add stats/incr/nanme Mar 15, 2025
@satansin123 satansin123 changed the title feat(stats): add stats/incr/nanme feat: add stats/incr/nanme Mar 15, 2025
@satansin123

satansin123 commented Mar 15, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 15, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 15, 2025
@satansin123

satansin123 commented Mar 16, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 16, 2025
@stdlib-bot

stdlib-bot commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

@satansin123, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 16, 2025
@satansin123

satansin123 commented Mar 16, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib check-files

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 16, 2025
@stdlib-bot

stdlib-bot commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

Hi @satansin123, thank you for your contribution!

🎉 Your pull request contains all required files for the new package: 🎉

  • package.json
  • README.md
  • docs/repl.txt
  • docs/types/index.d.ts
  • docs/types/test.ts
  • lib/index.js
  • lib/main.js
  • benchmark/benchmark.js
  • examples/index.js
  • test/test.js

-- stdlib-bot

@stdlib-bot stdlib-bot removed bot: In Progress Pull request is currently awaiting automation. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 16, 2025
@satansin123

satansin123 commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 18, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 18, 2025
@satansin123

satansin123 commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 18, 2025
Planeshifter
Planeshifter requested changes Mar 10, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread lib/node_modules/@stdlib/stats/incr/nanme/lib/main.js Resolved
Comment thread lib/node_modules/@stdlib/stats/incr/nanme/examples/index.js Resolved
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
@Planeshifter Planeshifter mentioned this pull request Jul 15, 2026
Closed
@Planeshifter
Planeshifter requested a review from a team July 16, 2026 04:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 16, 2026
@Planeshifter

Planeshifter commented Jul 16, 2026

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jul 16, 2026
@Planeshifter
Planeshifter force-pushed the feature/adding-nanme-package-5570 branch 2 times, most recently from 38bdf8f to 9e8ed39 Compare July 16, 2026 05:24
@Planeshifter
fix: address review feedback
fb97408 
- Refactor to wrap incrme instead of reimplementing with incrmean
- Fix variable name inconsistency in lib/index.js
- Fix format specifiers in examples/index.js
- Add missing accumulator call in README example loop
- Use relative require path in test.js and benchmark.js
- Update copyright years to 2026
@Planeshifter
Planeshifter force-pushed the feature/adding-nanme-package-5570 branch from 9e8ed39 to fb97408 Compare July 16, 2026 05:29
Planeshifter
Planeshifter approved these changes Jul 17, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it!

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jul 17, 2026
@stdlib-bot

stdlib-bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/incr/nanme`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6077
Closes: https://github.com/stdlib-js/stdlib/issues/5570

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit d913a08 into stdlib-js:develop Jul 17, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments
@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanme

3 participants

@satansin123 @stdlib-bot @Planeshifter